Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semver) trim -redhat from KIC tags #779

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix(semver) trim -redhat from KIC tags #779

merged 2 commits into from
Apr 6, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Apr 5, 2023

What this PR does / why we need it:

Strip -redhat suffix from KIC tags if present.

We use this to indicate Docker image variants. It is not actually a semver pre-release, but the semver functions can't tell the difference.

Release 2.17.1.

Which issue this PR fixes

Special notes for your reviewer:

Compare, with the change:

15:12:10-0700 esenin $ helm template ct /tmp/symkong --set ingressController.image.tag=2.9.0-redhat | grep cmetrics -A1
        - name: cmetrics
          containerPort: 10255

15:12:14-0700 esenin $ helm template ct /tmp/symkong --set ingressController.image.tag=2.9.0-other | grep cmetrics -A1 

15:12:23-0700 esenin $

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

Strip -redhat suffix from KIC tags if present.

We use this to indicate Docker image variants. It is not actually a
semver pre-release, but the semver functions can't tell the difference.
@rainest rainest requested a review from a team as a code owner April 5, 2023 22:15
@pmalek pmalek merged commit ff5d417 into main Apr 6, 2023
10 checks passed
@pmalek pmalek deleted the fix/tag-trim branch April 6, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm install fails to create rules for kongclusterplugins and kongingress when using an OS tagged image
2 participants