feat: add support for startupProbe on kong pods #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @slavogiez, thank you for the contribution! It looks reasonable to me. Would you mind adding an entry to the |
slavogiez
force-pushed
the
feat/startup-probe
branch
from
be4102f
to
21fd25a
Compare
|
Hi @czeslavo, thanks for your quick reply! I just added the entry in the changelog. Sorry for this, as I didn't the unreleased header, I thought it would be automatically generated during release. |
czeslavo
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When kong dataplanes need to load a large config, pods may take some time to be ready. Without the startup probe, we would need to increase failureThreshold or play with initialDelaySeconds, which would have negative side effect on responsiveness of these probes in case of real issues.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)No issue opened
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.