feat: add RBAC for watching CRDs by controller #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
crds-cluster-role
branch
from
7845048
to
cbd9104
Compare
czeslavo
force-pushed
the
crds-cluster-role
branch
from
cbd9104
to
b81c521
Compare
pmalek
reviewed
May 16, 2023
czeslavo
force-pushed
the
crds-cluster-role
branch
from
b81c521
to
0475ac3
Compare
pmalek
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
watchandlistpermissions forapiextensions.k8s.io.customresourcedefinitionsto controller'sClusterRoleto enable watching CRDs and start reconcilers dynamically once they get installed implemented in Kong/kubernetes-ingress-controller#3996.Which issue this PR fixes
Closes Kong/kubernetes-ingress-controller#3029.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.