Allow custom CommonName when cluster_mtls: pki
#804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
previously approved these changes
May 19, 2023
|
@pmalek This is my first contribution to charts. What's the process for merge + release? |
You'd bump the Line 14 in 4a86260 chart-releaser will figure it out that a release is required due to a bumped version and will do so accordingly.
|
pmalek
pushed a commit
that referenced
this pull request
May 25, 2023
* feat(hybrid): Allow setting CommonName when using PKI for mTLS * docs(hybrid): Add Hybrid mode w/ Cert Manager example * Add changelog entry + bump chart version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
CommonNamefor the cluster certificate must be set tokong_clusteringwhen running incluster_mtls: sharedmode. When running incluster_mtls: pkimode it can be any value that a CA will accept.I've also added some additional documentation. The existing README shows how to use hybrid mode with a shared certificate. When running with Cert Manager we need to switch to
pkimode.This PR adds example
values.yamlfiles + a README for this specific use case as it's come up a few times.Which issue this PR fixes
FTI-4396
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.