Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RBAC rules for KongConsumerGroups #850

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat: add RBAC rules for KongConsumerGroups #850

merged 1 commit into from
Aug 4, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Aug 4, 2023 •
edited

What this PR does / why we need it:

KIC 2.11 will need permission to watch KongConsumerGroups CRD and patch its status. This adds RBAC rules for that.
your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • [x] New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@czeslavo czeslavo self-assigned this Aug 4, 2023
@czeslavo czeslavo added the enhancement New feature or request label Aug 4, 2023
@czeslavo czeslavo marked this pull request as ready for review August 4, 2023 16:47
@czeslavo czeslavo requested a review from a team as a code owner August 4, 2023 16:47
rainest
rainest approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need version gates on these, since requesting permissions for non-existent resource kinds is fine. We already did it for Endpoints/EndpointSlices though, so 🤷

@rainest rainest merged commit d8933b7 into main Aug 4, 2023
22 checks passed
@rainest rainest deleted the consumer-groups-rbac branch August 4, 2023 22:38
@oldium
Copy link

oldium commented Aug 15, 2023

Shouldn't KongConsumerGroups be added to charts/kong/crds/custom-resource-definitions.yaml too?

@pmalek
Copy link
Member

pmalek commented Aug 16, 2023

@oldium I believe e1e1c34 added it

@oldium
Copy link

oldium commented Aug 16, 2023

@oldium I believe e1e1c34 added it

Yep, you are right. That indeed addresses my issue 😊. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainest rainest rainest approved these changes

Assignees

@czeslavo czeslavo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@czeslavo @oldium @pmalek @rainest