Disable PodDisruptionBudget for replicaCount: 1 #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Can you make this a template fail condition instead of silently deleting the resource?
AFAICT this should only happen on accidental misconfiguration (there's no way to reconcile a single-replica release with a disruption budget), so this should probably immediately fail in the client, to alert you to choose either multiple replicas or no PDB.
|
Sure :) I've changed the template to fail on both |
Check if replicaCount is above 1 before including the PodDisruptionBudget when enabled. Installations leaving replicaCount: 1 as default and specifying podDisruptionBudget.enabled: true will prevent kong Deployments from progressing during upgrades. Signed-off-by: Gerald Pape <gerald@giantswarm.io>
… autoscaling minReplicas Signed-off-by: Gerald Pape <gerald@giantswarm.io>
Signed-off-by: Gerald Pape <gerald@giantswarm.io>
ubergesundheit
force-pushed
the
disable-pdb-on-one-replica
branch
from
77bff30
to
4b4cb0b
Compare
rainest
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Check if replicaCount is above 1 before including the PodDisruptionBudget when enabled.
Installations leaving
replicaCount: 1as default and specifyingpodDisruptionBudget.enabled: truewill prevent kong Deployments from progressing during upgrades.Checklist
mainbranch.