Two more typos for namespace, README whitespaces at the end of the lines #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
reviewed
Jan 21, 2020
charts/kong/README.md
Outdated
| @@ -178,7 +178,7 @@ Kong can be configured via two methods: | |||
| on Kong Ingress Controller. | |||
| To configure and fine-tune the controller, please read the | |||
| [Ingress Controller Parameters](#ingress-controller-parameters) section. | |||
| - **Admin API** | |||
| - **Admin API** | |||
There was a problem hiding this comment.
Can you revert these double white space changes? They are required to push content to the next line.
Other white space changes in the lines below this comment are fine.
There was a problem hiding this comment.
Using whitespaces at the end of the line is a bad idea, as many people (including me) have auto-removal on save enabled in editor :)
Much better idea is just put \ at the end of the line to force line break, which I did in last comment :)
There was a problem hiding this comment.
TIL \ is a thing in markdown. Thank you!
Can you also do this for other white spaces that are removed in the diff currently in lines above (Runtime packages section)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I've missed two more typos :/