feat(kong): allow using templates when specifying controller.proxy.nameOverride

[pmalek]

What this PR does / why we need it:

When using the ingress chart
we have to specify the proxy name override

charts/charts/ingress/values.yaml

Line 7 in 824d022

nameOverride: kong-gateway-proxy

in order to get controller's CONTROLLER_PUBLISH_SERVICE set properly.

Currently the override is set to kong-gateway-proxy which works only when the release name (set by the user) is kong. When a different release name is chosen users have to know what to change and how to change it, e.g. when using a release name kong123 controller.proxy.nameOverride has to be set to kong123-gateway-proxy.

Without this change installing the ingress chart using kong123 release name yields the following controller env variables:

- name: CONTROLLER_KONG_ADMIN_SVC
  value: kong/kong123-gateway-admin
- name: CONTROLLER_PUBLISH_SERVICE
  value: kong/kong-gateway-proxy

With this change:

- name: CONTROLLER_KONG_ADMIN_SVC
  value: kong/kong123-gateway-admin
- name: CONTROLLER_PUBLISH_SERVICE
  value: kong/kong123-gateway-proxy

without the user specifying the override themselves.

Release kong/kong chart 2.30.0.

[czeslavo]

👍

[pmalek]

Holding this for @mheap's review

[mheap]

LGTM. Should we deprecate gatewayDiscovery.generateAdminApiService to use tpl for admin service discovery too?

[pmalek]

LGTM. Should we deprecate gatewayDiscovery.generateAdminApiService to use tpl for admin service discovery too?

I'm not sure but even if that should be a separate PR.