-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add KongServiceFacade RBACs, release kong/kong 2.33.0 #963
Conversation
b462330
to
e01ba9c
Compare
@pmalek I changed the |
I do recall there was a discussion about this at some point. Perhaps @programmer04 or @rainest can chip in. I believe one of the arguments against it was that we wouldn't explicitly know which version are we using at particular point in time (it would be the current version during the helm dependency update invocation). Now we don't have that solve either, we only have the minimal version and we rebuild the deps on release (this is similar to what you proposed in this PR). I'm not sure what would be the best approach for this 🤔 |
e01ba9c
to
f594e9f
Compare
👍 Alright, to not block this PR on this, I backed off to only |
What this PR does / why we need it:
Adds
KongServiceFacade
RBAC rules and releaseskong/kong
2.33.0.both charts (changed theingress
'sChart.yaml
to refer tokong
byfile://
instead ofhttps://
which allows bumping both charts in a single commit).Which issue this PR fixes
Part of Kong/kubernetes-ingress-controller#5152.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.