Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KongServiceFacade RBACs, release kong/kong 2.33.0 #963

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 6, 2023

What this PR does / why we need it:

Adds KongServiceFacade RBAC rules and releases kong/kong 2.33.0. both charts (changed the ingress's Chart.yaml to refer to kong by file:// instead of https:// which allows bumping both charts in a single commit).

Which issue this PR fixes

Part of Kong/kubernetes-ingress-controller#5152.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@czeslavo czeslavo self-assigned this Dec 6, 2023
@czeslavo czeslavo added enhancement New feature or request area/release labels Dec 6, 2023
@czeslavo czeslavo force-pushed the kong-service-facade-rbac branch 7 times, most recently from b462330 to e01ba9c Compare December 6, 2023 10:08
@czeslavo czeslavo marked this pull request as ready for review December 6, 2023 12:10
@czeslavo czeslavo requested a review from a team as a code owner December 6, 2023 12:10
charts/ingress/Chart.lock Outdated Show resolved Hide resolved
charts/ingress/Chart.lock Outdated Show resolved Hide resolved
charts/ingress/Chart.yaml Outdated Show resolved Hide resolved
charts/ingress/Chart.yaml Outdated Show resolved Hide resolved
@czeslavo
Copy link
Contributor Author

czeslavo commented Dec 6, 2023

@pmalek I changed the kong/kong repository from https:// to file:// deliberately to allow bumping both charts in a single commit. Is this something that we'd like to avoid? As I understand, we always want to make them be in sync - that enables us to make it happen without an additional PR to bump kong/ingress dependencies separately.

@pmalek
Copy link
Member

pmalek commented Dec 6, 2023

@pmalek I changed the kong/kong repository from https:// to file:// deliberately to allow bumping both charts in a single commit. Is this something that we'd like to avoid? As I understand, we always want to make them be in sync - that enables us to make it happen without an additional PR to bump kong/ingress dependencies separately.

I do recall there was a discussion about this at some point. Perhaps @programmer04 or @rainest can chip in. I believe one of the arguments against it was that we wouldn't explicitly know which version are we using at particular point in time (it would be the current version during the helm dependency update invocation). Now we don't have that solve either, we only have the minimal version and we rebuild the deps on release (this is similar to what you proposed in this PR).

I'm not sure what would be the best approach for this 🤔

@czeslavo
Copy link
Contributor Author

czeslavo commented Dec 6, 2023

👍 Alright, to not block this PR on this, I backed off to only kong/kong changes and will proceed with a separate PR bumping this in kong/ingress.

@czeslavo czeslavo requested a review from pmalek December 6, 2023 13:04
@czeslavo czeslavo changed the title feat: add KongServiceFacade RBACs, release charts feat: add KongServiceFacade RBACs, release kong/kong 2.33.0 Dec 6, 2023
@czeslavo czeslavo enabled auto-merge (squash) December 6, 2023 13:23
@czeslavo czeslavo merged commit e44817a into main Dec 6, 2023
23 checks passed
@czeslavo czeslavo deleted the kong-service-facade-rbac branch December 6, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants