Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(env) add support for envFrom #987

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat(env) add support for envFrom #987

merged 1 commit into from
Jan 19, 2024

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jan 19, 2024

What this PR does / why we need it:

Add envFrom and ingressController.envFrom values. These populate the standard container envFrom field, which contains a list of ConfigMap or Secret refs. Keys and values from the referenced resources are set as environment variables in the containers.

Which issue this PR fixes

Aha idea KIC-I-52 from @felderi

Special notes for your reviewer:

The root-level envFrom violates the modern rule about placing config for the Deployment under the deployment key. I put it there for consistency with the existing env and customEnv values.

This uses the envFrom key to populate envFrom in the Deployment Kong container as well as the init containers and migrations containers. Several of these only appear in DB mode. test2-values uses Postgres and the the controller, so it hits every use of this value in templates.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

Add envFrom and ingressController.envFrom values. These populate the
standard container envFrom field, which contains a list of ConfigMap or
Secret refs. Keys and values from the referenced resources are set as
environment variables in the containers.
@rainest rainest marked this pull request as ready for review January 19, 2024 03:07
@rainest rainest requested a review from a team as a code owner January 19, 2024 03:07
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 5e7c7ce into main Jan 19, 2024
23 checks passed
@tao12345666333 tao12345666333 deleted the feat/envfrom branch January 19, 2024 03:50
rainest added a commit that referenced this pull request Jan 19, 2024
Add envFrom and ingressController.envFrom values. These populate the
standard container envFrom field, which contains a list of ConfigMap or
Secret refs. Keys and values from the referenced resources are set as
environment variables in the containers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants