Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add envFrom and ingressController.envFrom values. These populate the standard container envFrom field, which contains a list of ConfigMap or Secret refs. Keys and values from the referenced resources are set as environment variables in the containers.
Which issue this PR fixes
Aha idea KIC-I-52 from @felderi
Special notes for your reviewer:
The root-level
envFrom
violates the modern rule about placing config for the Deployment under thedeployment
key. I put it there for consistency with the existingenv
andcustomEnv
values.This uses the
envFrom
key to populateenvFrom
in the Deployment Kong container as well as the init containers and migrations containers. Several of these only appear in DB mode. test2-values uses Postgres and the the controller, so it hits every use of this value in templates.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.