[kong] migrate controller to envvar-based configuration #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the default TLS verify setting out of the controller helper template and into its env block in values.yaml. Add a commented example section for the specifying the controller's admin token.
Remove the static command-line arguments from the controller template and replace them with equivalent environment variables. This breaks compatibility with controller versions <0.7. Separate the render section of the existing kong.env template into its own kong.renderEnv template, which is now used for both the Kong and controller container env blocks.
Set kong_admin_tls_skip_verify to true by default when generating the controller env block. Although this is now set in the standard values.yaml, since the previous values.yaml set env to the empty object, upgraded instances would default to false unless that section was omitted or updated. The setting in values.yaml will still take precedence if present.
hbagdi
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
envblock generation to the dict-based system used by the Kong container.kong_admin_tls_skip_verifydefault and examplekong_admin_tokenin values.yaml.Special notes for your reviewer:
POD_NAMESPACEandPOD_NAMEremain outside the new system (they're still part of thekong.controller-containertemplate). Users cannot override them (user variables all receive theCONTROLLER_prefix) and we'd need an additional (albeit simple) template to handle fieldRefs, so I think it's reasonable to omit them.kong_admin_tls_skip_verifyis now a user-set variable with a default in values.yaml, it also has a default inside the template. This is to account for users with an existing values.yaml that specifiesenv: {}.Checklist
nextbranch and targetsnext, notmaster[kong])