Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RBAC rules for KongVault #992

Merged
merged 2 commits into from
Jan 29, 2024
Merged

feat: add RBAC rules for KongVault #992

merged 2 commits into from
Jan 29, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jan 29, 2024

What this PR does / why we need it:

Adds a cluster RBAC rule for KongVault to be installed when KIC version >= 3.1.0.

Which issue this PR fixes

Fixes Kong/kubernetes-ingress-controller#5471.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@czeslavo czeslavo self-assigned this Jan 29, 2024
@czeslavo czeslavo changed the title feat: add RBAC rules for KongVault feat: add RBAC rule for KongVault Jan 29, 2024
@czeslavo czeslavo marked this pull request as ready for review January 29, 2024 10:44
@czeslavo czeslavo requested a review from a team as a code owner January 29, 2024 10:44
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
@czeslavo czeslavo changed the title feat: add RBAC rule for KongVault feat: add RBAC rules for KongVault Jan 29, 2024
@czeslavo czeslavo requested a review from pmalek January 29, 2024 11:50
@czeslavo czeslavo enabled auto-merge (squash) January 29, 2024 11:58
@czeslavo czeslavo merged commit a8c3822 into main Jan 29, 2024
24 checks passed
@czeslavo czeslavo deleted the feat/kongvault-rbacs branch January 29, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KongVault add RBAC rules in controller role to chart
2 participants