Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated konnect flag cannot manage non-default CPs #1036

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@GGabriele GGabriele marked this pull request as ready for review September 27, 2023 09:50
@GGabriele GGabriele requested a review from a team as a code owner September 27, 2023 09:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (c155000) 33.65% compared to head (e62fade) 33.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
- Coverage   33.65%   33.58%   -0.07%     
==========================================
  Files         101      101              
  Lines       12409    12430      +21     
==========================================
- Hits         4176     4175       -1     
- Misses       7824     7848      +24     
+ Partials      409      407       -2     
Files Coverage Δ
utils/types.go 14.12% <ø> (ø)
cmd/common_konnect.go 7.03% <0.00%> (-0.30%) ⬇️
cmd/common.go 3.96% <0.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GGabriele GGabriele merged commit 84e9bba into main Sep 27, 2023
35 checks passed
@GGabriele GGabriele deleted the fix/control-plane-name branch September 27, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants