Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): deprecated commands default to kong.yaml #1073

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 1, 2023

2 Cobra commands were generated; deprecated, and current. Both would point to the same golbal variable.
The bug is that Cobra sets the defaults when CREATING the command not when parsing. This means that the last command created would set the global defaults, and hence overwrite the ones from the other command.

Introduced in #962

Jira: DECK-156

.vscode/launch.json Outdated Show resolved Hide resolved
2 Cobra commands were generated; deprecated, and current. Both
would point to the same golbal variable.
The bug is that Cobra sets the defaults when CREATING the command
not when parsing. This means that the last command created would
set the global defaults, and hence overwrite the ones from the
other command.

Introduced in #962

Jira: DECK-156
@codecov-commenter
Copy link

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (48e236c) 32.92% compared to head (5ebe4ba) 32.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
- Coverage   32.92%   32.87%   -0.05%     
==========================================
  Files         103      103              
  Lines       12831    12847      +16     
==========================================
  Hits         4224     4224              
- Misses       8198     8214      +16     
  Partials      409      409              
Files Coverage Δ
cmd/gateway_dump.go 0.00% <0.00%> (ø)
cmd/file_convert.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tieske Tieske merged commit d110df8 into main Nov 1, 2023
34 of 35 checks passed
@Tieske Tieske deleted the fix/cli-defaults branch November 1, 2023 11:26
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
2 Cobra commands were generated; deprecated, and current. Both would point to the same golbal variable.
The bug is that Cobra sets the defaults when CREATING the command not when parsing. This means that the last command created would set the global defaults, and hence overwrite the ones from the other command.

Introduced in #962

Jira: DECK-156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants