tests: fix konnect integration tests #1101
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
reviewed
Nov 9, 2023
| @@ -258,7 +261,7 @@ func setup(t *testing.T) { | |||
|
|
|||
| func sync(kongFile string, opts ...string) error { | |||
| deckCmd := cmd.NewRootCmd() | |||
| args := []string{"sync", "-s", kongFile} | |||
| args := []string{"gateway", "sync", kongFile} | |||
There was a problem hiding this comment.
We are keeping the "old" syntax on purpose here since we care more about not breaking existing workflows than introducing possible bugs into new functionalities. @Tieske has some WIP task to improve our posture here.
|
These tests seem rather brittle anyway, probably due to the nature of using an external service like Konnect. 🤔 Might need more work to make them bullet proof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.