Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-generate rla's namespace on 'convert' subcommand #1206

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@mheap
Copy link
Member

mheap commented Feb 6, 2024

@GGabriele Thank you! Are there any other plugins that you know of that could benefit from the same conversion?

@GGabriele
Copy link
Collaborator Author

The only other EE Plugins with auto = true fields are the following, but none of these fields are required, so the plugin creation would be successful even without them:

  • graphql-rate-limiting-advanced (namespace)
  • kafka-log (cluster_name)
  • kafka-upstream (cluster_name)
  • openid-connect (cache_tokens_salt)

@mheap
Copy link
Member

mheap commented Feb 6, 2024

Does the standard rate-limiting plugin have the same required field (and/or can you explain how I can check myself so that I can save you some time?)

@GGabriele GGabriele marked this pull request as ready for review February 14, 2024 11:25
@GGabriele GGabriele requested a review from a team as a code owner February 14, 2024 11:25
@Tieske Tieske merged commit a18140f into main Feb 15, 2024
38 of 39 checks passed
@Tieske Tieske deleted the feat/namespace-convert branch February 15, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants