Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Konnect readiness validation #1227

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

johnharris85
Copy link
Contributor

This PR adds a --konnect-compatibility flag to deck gateway validate that tries to codify the rules / guidelines around plugins and general configuration to make it easier for users to assess their Konnect readiness from an existing decK state (and potentially integrate into an automated pipeline).

It will check:

  • If there are any plugins present that are incompatible with Konnect (e.g. oauth2)
  • If there are options for specific plugins that are incompatible with Konnect (e.g. cluster strategy for RLA, etc...)
  • If a _workspace is set
  • If the version is incompatible (e.g. "1.1", etc...)

Signed-off-by: John Harris <john@johnharris.io>
@johnharris85 johnharris85 requested a review from a team as a code owner February 21, 2024 22:27
cmd/gateway_validate.go Outdated Show resolved Hide resolved
@mheap
Copy link
Member

mheap commented Mar 6, 2024

@johnharris85 LGTM - let's add some tests and ship

Signed-off-by: John Harris <john@johnharris.io>
@johnharris85 johnharris85 changed the title [WIP] feat: add Konnect readiness validation feat: add Konnect readiness validation Mar 29, 2024
@mheap mheap requested a review from GGabriele April 3, 2024 10:08
@GGabriele GGabriele merged commit 40d355a into Kong:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants