Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nil error when port not defined in service with Gateway API. #1230

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Handle nil error when port not defined in service with Gateway API. #1230

merged 2 commits into from
Mar 1, 2024

Conversation

battlebyte
Copy link
Collaborator

Fixes 3 issues in kong2kic:

  1. Handles nil pointer error when service port is not specified and output style is Gateway API
  2. Handles the case in which no HTTP method is specified in a Route
  3. Add annotation from service to upstream only when relationship is found.

@battlebyte battlebyte requested a review from a team as a code owner February 29, 2024 15:12
@battlebyte battlebyte changed the title Handle nil error when port not defined in service with Gateway API. H… Handle nil error when port not defined in service with Gateway API. Feb 29, 2024
@Tieske
Copy link
Member

Tieske commented Mar 1, 2024

@czeslavo would you mind having a look at this, lgtm, but would like a k8s/kic double-check

@Tieske Tieske requested a review from czeslavo March 1, 2024 08:32
czeslavo
czeslavo reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one cosmetic nit, LGTM 👍

kong2kic/route.go Outdated Show resolved Hide resolved
@Tieske Tieske merged commit ce8628e into main Mar 1, 2024
39 checks passed
@Tieske Tieske deleted the fix/kong2kic-np branch March 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo left review comments

@Tieske Tieske Tieske approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@battlebyte @Tieske @czeslavo