feat(apiops): add host-based namespacing #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLI help and examples still need to be added. |
|
CLI text added, ready for review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
+ Coverage 21.52% 21.69% +0.17%
==========================================
Files 53 53
Lines 5385 5452 +67
==========================================
+ Hits 1159 1183 +24
- Misses 4135 4176 +41
- Partials 91 93 +2 ☔ View full report in Codecov by Sentry. |
rspurgeon
reviewed
Mar 7, 2024
|
Is this PR still pending test additions for the new flags and features? |
The CLI unfortunately doesn't have any tests, there was an attempt a long time ago, but it was abandoned and never restarted. |
This completes the namespace feature, by adding the hostbased namespacing to the existing path-based namespacing. See Kong/go-apiops#129 (comment) for an explanation.
GGabriele
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the namespace feature, by adding the host-based
namespacing to the existing path-based namespacing.
See Kong/go-apiops#129 (comment)
for an explanation.