Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1282 Updated git workflows to use go.mod for go versions #1336

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Prashansa-K
Copy link
Contributor

This would fix issue #1282.
Fetching the version directly from go.mod would help us to maintain consistency in the project and the released versions.

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
All committers have signed the CLA.

@Prashansa-K Prashansa-K linked an issue Jul 16, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.46%. Comparing base (57c8e3c) to head (6fe307a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
+ Coverage   22.39%   22.46%   +0.06%     
==========================================
  Files          54       54              
  Lines        4514     4514              
==========================================
+ Hits         1011     1014       +3     
+ Misses       3403     3401       -2     
+ Partials      100       99       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@Prashansa-K Prashansa-K merged commit c7109a9 into main Jul 16, 2024
40 of 41 checks passed
@Prashansa-K Prashansa-K deleted the chore/fix-go-version-in-workflows branch July 16, 2024 08:33
@Prashansa-K Prashansa-K self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update go version to 1.21.9 or 1.22.2
4 participants