Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add consumer group tags support #823

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

aboudreault
Copy link
Contributor

@aboudreault aboudreault commented Jan 19, 2023

This PR:

  • Add ConsumerGroup tags
  • Add Konnect Update functionality for ConsumerGroup and ConsumerGroupMember
  • Fix the index lookup of ConsumerGroupConsumersCollection.Update
  • Fix the index lookup of ConsumerGroupPluginsCollection.Update
  • Fix consumerGroupConsumerCRUD.Update for konnect+gateway support
  • Fix consumerGroupPluginCRUD.Update to return the proper ID
  • Add ConsumerGroup update tests for gateway and konnect
  • Update go-kong to 0.35
  • Update the CI enterprise matrix to use the latest patch release.

@aboudreault aboudreault temporarily deployed to Configure ci January 19, 2023 02:14 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 19, 2023 13:15 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 19, 2023 13:15 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 35.49% // Head: 35.39% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (3ae71be) compared to base (b62a3f6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   35.49%   35.39%   -0.10%     
==========================================
  Files          92       92              
  Lines       11230    11261      +31     
==========================================
  Hits         3986     3986              
- Misses       6847     6878      +31     
  Partials      397      397              
Impacted Files Coverage Δ
crud/registry.go 100.00% <ø> (ø)
konnect/consumer_group.go 0.00% <0.00%> (ø)
state/consumer_group.go 0.00% <0.00%> (ø)
state/consumer_group_consumers.go 0.00% <0.00%> (ø)
state/consumer_group_plugin.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aboudreault aboudreault force-pushed the feat/add-consumer-group-tags-support branch from b169da7 to 5119650 Compare January 23, 2023 13:53
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 13:53 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 13:53 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 14:15 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 14:15 — with GitHub Actions Inactive
@aboudreault aboudreault force-pushed the feat/add-consumer-group-tags-support branch from 3ae71be to 2217acc Compare January 23, 2023 15:20
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 15:20 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 15:20 — with GitHub Actions Inactive
@aboudreault aboudreault force-pushed the feat/add-consumer-group-tags-support branch from 2217acc to b641278 Compare January 23, 2023 17:44
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 17:44 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 17:45 — with GitHub Actions Inactive
@aboudreault aboudreault force-pushed the feat/add-consumer-group-tags-support branch from b641278 to a9b6e62 Compare January 23, 2023 17:45
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 17:45 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 17:45 — with GitHub Actions Inactive
@aboudreault aboudreault changed the title ttt: add consumer group support and fix update bugs feat: add consumer group tags support Jan 23, 2023
@aboudreault aboudreault force-pushed the feat/add-consumer-group-tags-support branch from a9b6e62 to 331ffd5 Compare January 23, 2023 18:18
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 18:18 — with GitHub Actions Inactive
@aboudreault aboudreault temporarily deployed to Configure ci January 23, 2023 18:18 — with GitHub Actions Inactive
@aboudreault aboudreault marked this pull request as ready for review January 23, 2023 18:26
@aboudreault aboudreault requested a review from a team as a code owner January 23, 2023 18:26
Copy link
Collaborator

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!!!

@aboudreault aboudreault merged commit 9fcabab into main Jan 23, 2023
@aboudreault aboudreault deleted the feat/add-consumer-group-tags-support branch January 23, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants