Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle konnect runtime groups pagination properly #841

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

aboudreault
Copy link
Contributor

  • fix: handle konnect runtime groups pagination properly
  • fix http response error handling

@aboudreault aboudreault requested a review from a team as a code owner February 8, 2023 21:02
@aboudreault aboudreault temporarily deployed to Configure ci February 8, 2023 21:02 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Base: 35.45% // Head: 35.42% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (acc0cb3) compared to base (629712b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
- Coverage   35.45%   35.42%   -0.04%     
==========================================
  Files          92       92              
  Lines       11247    11258      +11     
==========================================
  Hits         3988     3988              
- Misses       6862     6873      +11     
  Partials      397      397              
Impacted Files Coverage Δ
cmd/common_konnect.go 6.71% <0.00%> (-0.18%) ⬇️
konnect/list.go 0.00% <0.00%> (ø)
utils/types.go 14.88% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mikefero mikefero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aboudreault aboudreault merged commit 0ae9347 into main Feb 8, 2023
@aboudreault aboudreault deleted the fix/runtime-list-panic-issue branch February 8, 2023 22:39
@aboudreault
Copy link
Contributor Author

thanks @GGabriele for your quick and great investigation on this issue!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants