Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated konnect subcommands #910

Closed
wants to merge 1 commit into from
Closed

Conversation

voigtjr
Copy link
Member

@voigtjr voigtjr commented May 15, 2023

The deprecated konnect subcommands rely on the deactivated konnect.konghq.com domain and is now broken because of that. These changes remove the deprecated subcommands.

@voigtjr voigtjr requested a review from a team May 15, 2023 20:31
@CLAassistant
Copy link

CLAassistant commented May 15, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@voigtjr voigtjr changed the title Remove deprecated konnect subcommands chore: remove deprecated konnect subcommands May 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.93 🎉

Comparison is base (7189614) 35.57% compared to head (e549d9a) 36.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
+ Coverage   35.57%   36.51%   +0.93%     
==========================================
  Files          92       87       -5     
  Lines       11279    10991     -288     
==========================================
  Hits         4013     4013              
+ Misses       6873     6585     -288     
  Partials      393      393              
Impacted Files Coverage Δ
cmd/common_konnect.go 11.04% <ø> (+4.33%) ⬆️
cmd/root.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tieske
Copy link
Member

Tieske commented Jun 12, 2023

should this be targeted at the v2 branch? see #941

@voigtjr voigtjr closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants