Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add short-hand '-o' flag to convert #965

Closed
wants to merge 7 commits into from

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jul 17, 2023

also fixes the file-convert command to use positional args like the other "file" based commands. But since that hasn't been released yet, it is not a "user-facing" fix.

@Tieske Tieske requested a review from a team July 17, 2023 15:32
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (57734db) 33.95% compared to head (25516b5) 33.91%.

Additional details and impacted files
@@               Coverage Diff               @@
##           feat/render     #965      +/-   ##
===============================================
- Coverage        33.95%   33.91%   -0.04%     
===============================================
  Files              101      101              
  Lines            11989    12003      +14     
===============================================
  Hits              4071     4071              
- Misses            7519     7533      +14     
  Partials           399      399              
Impacted Files Coverage Δ
cmd/file_convert.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tieske Tieske modified the milestones: 1.24.0, 1.25.0 Jul 17, 2023
@Tieske
Copy link
Member Author

Tieske commented Jul 18, 2023

also moved to milestone 1.25 (following the base branch)

@Tieske Tieske force-pushed the feat/render branch 2 times, most recently from a0c7951 to 05e47cb Compare July 25, 2023 09:39
@Tieske
Copy link
Member Author

Tieske commented Jul 25, 2023

moved into #962

@Tieske Tieske closed this Jul 25, 2023
@Tieske Tieske deleted the fix/convert-args branch July 25, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants