HTTP Log Plugin missed updates (new fields, merge for CE 2.3.x on 1/20) #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for kongdocs ready! 🔨 Explore the source changes: efba8a1 🔍 Inspect the deploy logs: https://app.netlify.com/sites/kongdocs/deploys/5ffe1475d14ff90007dec265 😎 Browse the preview: https://deploy-preview-2393--kongdocs.netlify.app |
tlblessing
commented
Oct 19, 2020
tlblessing
commented
Oct 19, 2020
|
Never got any responses or time to track this down, but @javierguerragiraldez is updating this plugin in his PR #2535. Will port my edits there. Scratch that. Ported his 3 new fields to this PR. |
added 4 commits
January 11, 2021 15:34
tlblessing
changed the title
tlblessing
added
the
do not merge
javierguerragiraldez
approved these changes
Jan 11, 2021
lena-larionova
approved these changes
Jan 12, 2021
Thanks @lena-larionova ! I really need new glasses ASAP. |
tlblessing
changed the title
tlblessing
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://konghq.atlassian.net/browse/DOCS-1151 ticket logged for missing queue_size field but other fields and versions are also missing:
{ retry_count = { type = "integer", default = 10 }, }, { queue_size = { type = "integer", default = 1 }, }, { flush_timeout = { type = "number", default = 2 }, },{ content_type = { type = "string", default = "application/json", one_of = { "application/json" }, }, },local HttpLogHandler = { PRIORITY = 12, VERSION = "2.0.1",Added in new fields from @javierguerragiraldez, who was updating this plugin in his PR #2535 (closed):
The headers field is the 2.3-oriented update per https://github.com/Kong/kong/blob/changelog-2.3.0/CHANGELOG.md#230-rc1 and PR Kong/kong#6449.
Direct review link:
https://deploy-preview-2393--kongdocs.netlify.app/hub/kong-inc/http-log/
Questions for Reviewers @Kong/team-core:
I looked at the schema in the repo but do not see any additional information with descriptions of the missing fields. Please provide descriptions for (or point me to any code that contains them) Update: Already provided by Javier: