fix: make creating DataPlanes index conditional on enabling the ControlPlane controller #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
make-dataplane-index-for-controlplanes
branch
from
3403874
to
0b7a8b4
Compare
pmalek
force-pushed
the
make-dataplane-index-for-controlplanes
branch
from
0b7a8b4
to
8717003
Compare
…olPlane controller
pmalek
force-pushed
the
make-dataplane-index-for-controlplanes
branch
from
8717003
to
d8baecc
Compare
programmer04
approved these changes
Apr 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Creating a
DataPlaneindex is now conditional based on whetherControlPlanecontroller is enabled.This allows KGO to start without errors when
ControlPlanecontroller is disabled andControlPlaneCRD is not installed.Special notes for your reviewer:
This is going to be backported to 1.1.x and 1.2.x to allow smooth migration path.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes