chore(refactor): migrate project from Kubebuilder v3 to v4 layout #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
force-pushed
the
kubebuilder-layout
branch
5 times, most recently
from
e0b8231
to
4c01263
Compare
programmer04
force-pushed
the
kubebuilder-layout
branch
from
4c01263
to
21cf7a2
Compare
rainest
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Curious if we could make kubebuilder happier by symlinking its desired names to the actual (public) locations of the packages, but IDK if that causes havoc or how much benefit it'd really provide--I assume we'd still need to move newly-added things, so probably not much.
|
This will be a breaking change for CG dataplane-controller and we will need to coordinate its update when its KGO dependency is bumped to (probably) 1.3 which will include this change. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Inspired by
followed the official manual too.
This PR does not modify the API surface of KGO since it's currently used as a dependency in the enterprise built. Such efforts can be addressed in a separate PR.
Which issue this PR fixes
Part of #130
Special notes for your reviewer:
The layout proposed by
kubebuilderto movecontrollers->internal/controllercannot be implemented because they are pulled by KGO EE, so only renaming tocontrollerwas performed.Known limitation, calling e.g.
will put a newly created controller in
internal/controller. Maybe all controllers that are not pulled explicitly should be put there... It's something to consider and write down as a separate issue.The usage of
sedingenerate.clientsetsis not great but I tested it with bot BSD and GNUsedso I think we can live with it.