Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not require name/id for filter-chain entities #103

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Jun 11, 2024

Summary

This relaxes the JSON schema for filter chain entities to not require name or id. Filter chains are always associated with a service or a route and therefore do not require a name/id for indexing.

Issues resolved

KAG-4005

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.18%. Comparing base (1e34a0b) to head (486b477).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   41.18%   41.18%           
=======================================
  Files          74       74           
  Lines       10802    10802           
=======================================
  Hits         4449     4449           
  Misses       5891     5891           
  Partials      462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flrgh flrgh enabled auto-merge (squash) June 11, 2024 18:43
@flrgh flrgh force-pushed the fix/wasm-filter-chains-required-fields branch from 486b477 to cb0ea8a Compare June 12, 2024 17:03
@flrgh flrgh merged commit ac65306 into main Jun 13, 2024
42 checks passed
@flrgh flrgh deleted the fix/wasm-filter-chains-required-fields branch June 13, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants