Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong default filled for non-required field of type "record" #334

Closed
nishant95 opened this issue Jun 5, 2023 · 0 comments · Fixed by #336
Closed

wrong default filled for non-required field of type "record" #334

nishant95 opened this issue Jun 5, 2023 · 0 comments · Fixed by #336

Comments

@nishant95
Copy link
Contributor

Problem

handle_missing_fields in lua code and FillPluginsDefaults in go-kong has different handling for default values in the following scenario:

  • when the field is of type "record"
  • required is set to false
  • No subconfig provided for that field.

Kong Gateway fills the default as nil but KIC fills the default with a record object with nil fields.
This causes KIC to keep detecting diff and it gets stuck in sync retry loop and ultimately gets OOMKilled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fill defaults for non-required field of type "record" nishant95/go-kong
1 participant
@nishant95