Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure defaults are properly filled for a set #333

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

aboudreault
Copy link
Contributor

A recent bugfix caused a regression when filling defaults of a set type field (#309). This can be reproduced when using deck with a valid set field with values. The bootstrap_servers is defaulted to nil.

_format_version: "3.0"

plugins:
- name: kafka-log
  enabled: false
  config:
    topic: konnect.auditlogs.gateway-access-logs
    bootstrap_servers:
    - host: broker-1.endpoint
      port: 9096
    - host: broker-1.endpoint
      port: 9096
    - host: broker-1.endpoint
      port: 9096
    authentication:
      strategy: sasl
      mechanism: SCRAM-SHA-512
      user: sasl_user
      password: xxxxxxxx
    security:
      ssl: false
    cluster_name: konnect-msk
``

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +34.93 🎉

Comparison is base (482d841) 17.76% compared to head (85a672b) 52.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #333       +/-   ##
===========================================
+ Coverage   17.76%   52.69%   +34.93%     
===========================================
  Files          69       69               
  Lines        5093     5093               
===========================================
+ Hits          905     2684     +1779     
+ Misses       4099     1834     -2265     
- Partials       89      575      +486     
Flag Coverage Δ
2.2.1.3 46.65% <100.00%> (?)
2.2.2 17.47% <100.00%> (?)
2.3.3 17.63% <100.00%> (ø)
2.3.3.4 47.31% <100.00%> (?)
2.4.1 36.40% <100.00%> (?)
2.4.1.3 47.39% <100.00%> (?)
2.5.1.2 47.39% <100.00%> (?)
2.6.1 ?
2.6.1.0 47.39% <100.00%> (?)
2.7.2 17.71% <100.00%> (ø)
2.7.2.0 48.92% <100.00%> (?)
2.8.3 17.71% <100.00%> (ø)
2.8.4.0 48.92% <100.00%> (?)
3.0.2.0 49.38% <100.00%> (?)
3.1.1 ?
3.1.1.3 50.97% <100.00%> (?)
3.2.2.1 50.97% <100.00%> (?)
community 36.40% <100.00%> (+18.63%) ⬆️
enterprise 51.52% <100.00%> (?)
enterprise-nightly 50.97% <100.00%> (?)
integration 52.69% <100.00%> (+34.93%) ⬆️
nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/utils.go 88.02% <100.00%> (+1.19%) ⬆️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aboudreault aboudreault marked this pull request as ready for review June 5, 2023 14:47
@aboudreault aboudreault requested a review from a team as a code owner June 5, 2023 14:47
@aboudreault
Copy link
Contributor Author

aboudreault commented Jun 6, 2023

It would be great if we could review and merge this one today, since there is actually a regression in deck. #336 is probably also a good idea. Let me know if I can help more.

@GGabriele GGabriele requested a review from pmalek June 6, 2023 11:54
@rainest rainest merged commit 46c44eb into main Jun 6, 2023
43 checks passed
@rainest rainest deleted the fix/fill-config-default-set branch June 6, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants