Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fix): linting errors #126

Closed
wants to merge 3 commits into from
Closed

Conversation

darrenjennings
Copy link
Contributor

@darrenjennings darrenjennings commented Mar 10, 2019

  • util._extend -> Object.assign

  • .to.be.a.String -> .to.be.a.String() and others

  • remove unused requires to 'util'

  • remove unnecessarily escaped chars in tests

  • ignores node_modules from editorconfig, standard, echint

  • add Node 8 to travis to see lint + test ouput

Fixes #125

* util._extend -> Object.assign
* .to.be.a.String -> .to.be.a.String() and others
* remove unused requires to 'util'
* remove unnecessarily escaped chars in tests
* ignores node_modules  from editorconfig, standard, echint
@darrenjennings darrenjennings changed the base branch from master to next March 10, 2019 21:18
@darrenjennings darrenjennings deleted the chore/fix-linting-errors branch April 26, 2019 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant