add java async http client #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windard
force-pushed
the
add_java_asynchttp
branch
from
3614214
to
0fe2422
Compare
|
I hope somebody will see it , and approve&merge it as soon as possible. |
nijikokun
reviewed
May 22, 2020
src/targets/java/asynchttp.js
Outdated
|
|
||
| var code = new CodeBuilder(opts.indent) | ||
|
|
||
| // var methods = [ 'GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'HEAD', 'OPTIONS', 'TRACE', 'CONNECT' ] |
There was a problem hiding this comment.
delete leftover code
|
👋 Thank you for submitting this! Sorry it's taken a while to get some 👀 on it. I've left one comment, and others should start trickling in shortly ❤️ |
reynolek
approved these changes
May 26, 2020
windard
force-pushed
the
add_java_asynchttp
branch
from
0fe2422
to
6d3f7ee
Compare
Change-Id: Ic28431ae73b499e929545f95d746b1606fd639f3 fix double quote Change-Id: I7a8d4aa4cfd96159886436b89fc73096c9e740c5 fixture tests Change-Id: I355747450a1b47dc356ed97ba3da3c4b48ea6adc fix travis ci Change-Id: I88295b5adf157420052793c94b74dbdcb1abdaf3 small update Change-Id: Iabdddda1142500d14da1ab9157396d9871118130 close async http clinet Change-Id: Ie61baf7f5e19ed06e3799799d1604e6bf32a54fd delete leftover code Change-Id: I67c4b6e929903bd6a6e7e79cbbb596d2f33b0696
windard
force-pushed
the
add_java_asynchttp
branch
from
6d3f7ee
to
fa57cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Java AsyncHttpClient