New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updating javascript targets to use `const` instead of `var` #174

Merged

reynolek merged 1 commit into Kong:master from erunion:feat/js-consistency

Aug 17, 2020

Contributor

erunion commented Aug 7, 2020

Updates all Javascript and Node targets to use const instead of var.
Fixes some inconsistencies with the unirest target where it was adding unnecessary linebreaks and indents in snippets.
In the jquery target, I've added a semicolon to the settings object to stay consistent with the rest of the snippet.


          feat: updating javascript targets to use const instead of var

cd034d0

reynolek suggested changes

View reviewed changes

src/targets/node/request.js Show resolved Hide resolved

reynolek approved these changes

View reviewed changes

reynolek merged commit 155e563 into Kong:master

erunion deleted the feat/js-consistency branch

August 17, 2020 17:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment