Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating php targets to use [] instead of array() #175

Merged
merged 1 commit into from Aug 16, 2020

Conversation

erunion
Copy link
Contributor

@erunion erunion commented Aug 7, 2020

Does what it says on the tin. Updates all PHP targets to use [] for arrays instead of array(). Also updates a few instances of NULL to the more consistent null.

@reynolek
Copy link
Contributor

reynolek commented Aug 7, 2020

A benefit I can think of for keeping it to be array() is that it maintains support for php5 and array() still works in php7...That being said php5 is EOL as of Jan 2019.

@erunion
Copy link
Contributor Author

erunion commented Aug 7, 2020

I thought the same, but yeah PHP 5 isn't getting any new updates now so I don't think there's any reason to code against that expectation.

@reynolek reynolek merged commit 68cfbd0 into Kong:master Aug 16, 2020
@erunion erunion deleted the feat/cleaner-php branch August 17, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants