Adding node-fetch target #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develohpanda
reviewed
Oct 1, 2020
There was a problem hiding this comment.
Thanks for sorting this PR out @jgiovaresco! Looks good to me. One comment regarding JSON encoding, similar to #179. Some of the fixtures would change after that as well.
| headers: {'content-type': 'application/json'}, | ||
| body: { | ||
| number: 1, | ||
| string: 'f"oo', |
@hirenoble is the original author (Kong#154). I've just resolve conflicts and fix tests that were failing. @develohpanda noticed that JSON body should be stringified (https://github.com/node-fetch/node-fetch#post-with-json) And looking at fetch options (https://github.com/node-fetch/node-fetch#fetch-options) I noticed that `json` attribute does not exist, so I've removed it.
jgiovaresco
force-pushed
the
add-node-fetch-target
branch
from
4038723
to
ea9398c
Compare
|
@jgiovaresco Thanks a lot for taking care of that! I wasn't noticing any activity on this thread. |
develohpanda
pushed a commit
that referenced
this pull request
Oct 2, 2020
@hirenoble is the original author (#154). I've just resolve conflicts and fix tests that were failing. @develohpanda noticed that JSON body should be stringified (https://github.com/node-fetch/node-fetch#post-with-json) And looking at fetch options (https://github.com/node-fetch/node-fetch#fetch-options) I noticed that `json` attribute does not exist, so I've removed it. Co-authored-by: Julien Giovaresco <dev@giovaresco.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hirenoble is the original author (#154).
I've just resolve conflicts and fix tests that were failing.
@develohpanda noticed that JSON body should be stringified (https://github.com/node-fetch/node-fetch#post-with-json)
And looking at fetch options (https://github.com/node-fetch/node-fetch#fetch-options) I noticed that
jsonattribute does not exist, so I've removed it.Closes #152