Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --globoff option to shell_curl #199

Merged
merged 5 commits into from Apr 28, 2021

Conversation

adamrdavid
Copy link
Contributor

@adamrdavid adamrdavid commented Nov 10, 2020

In some common api specifications there exist nested query parameters that take the form of an object.
Example: page[limit]=10 https://jsonapi.org/

This PR

  1. Adds a fixture for nested query params and associated test cases
  2. Adds the --globoff or -g option for the curl command to allow unescaped brackets in the url

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@reynolek reynolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a recent change, we are converting over to using const and let rather than var. There is likely also a merge conflict with this exact issue as well. Would you mind sweeping through your new code and eliminating var, and then I can get this merged.

@reynolek
Copy link
Contributor

Thanks for knocking that out! Merging now.

@reynolek reynolek merged commit 71eec07 into Kong:master Apr 28, 2021
@adamrdavid adamrdavid deleted the curl-options-unescape branch September 21, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants