fix(curl) remove boundary form content-type header #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateslo
force-pushed
the
fix/multipart-curl-boundary
branch
from
559b147
to
673baec
Compare
reynolek
approved these changes
Sep 3, 2021
| @@ -39,6 +40,22 @@ module.exports = function (source, options) { | |||
| code.push(opts.short ? '-0' : '--http1.0') | |||
| } | |||
|
|
|||
| // if multipart form data, we want to remove the boundary | |||
There was a problem hiding this comment.
Per #226, we discussed just scoping this to fixing cURL due to how cURL handles --form vs raw data.
Did you attempt any kind of audit of other targets to see if they are impacted by similar issues?
There was a problem hiding this comment.
I have not investigate any other targets yet, this fix only pertains to curl multipart
| if (contentTypeHeaderName && contentTypeHeader) { | ||
| // remove the leading semi colon and boundary | ||
| // up to the next semi colon or the end of string | ||
| const noBoundary = contentTypeHeader.replace(/; boundary.+?(?=(;|$))/, '') |
There was a problem hiding this comment.
I double checked these regex and functions as expected.
erunion
approved these changes
Sep 3, 2021
No worries! Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #226
This PR removes the boundary from the content-type header for curl multipart request. Curl appends its own boundary when using
--form, resulting in a double boundary.