This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
feat(cosmetic): update to match apple guidelines #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysoekong
changed the title
tysoekong
force-pushed
the
update_to_apple_guildelines
branch
from
1164d2c
to
c3b317c
Compare
|
Looks good to me! Thanks @tysoekong ! @erickrico , please take a look and tweak as needed :) |
tysoekong
changed the title
tysoekong
changed the title
|
The logo might need to diverge for different platforms now - wonder whether the Windows/others icon should remain the distinctive circle logo, whereas the macOS one should adhere to Apple guidelines? It's complicated... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current icon does not conform to Apple's new design guildelines for macOS Big Sur (11.0) and onwards:
https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon
It should be a .25 radius rounded square, and a .4 drop-shadow. See the example icon resource render, as it would appear in the dock:
Important: I don't have Serif Affinity Designer, so I was unable to update the actual render, however you could use this PR as an example to regenerate the whole icon set, just need to add the rectangle and filter to the Serif file.