Skip to content

Commit

Permalink
Bump/electron-30 (#7354)
Browse files Browse the repository at this point in the history
* bump node

* bump electron

* pin node v

* bump libcurl

* fix lock

* use stable

* types

* latest electron
  • Loading branch information
jackkav committed Jun 5, 2024
1 parent 2033709 commit 50965a4
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
runtime = electron
target = 29.0.0
target = 30.0.0
disturl = https://electronjs.org/headers
playwright_skip_browser_download=true
engine-strict=true
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.9.0
20.11.1
22 changes: 11 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"homepage": "https://github.com/kong/insomnia#readme",
"engines": {
"node": ">=20.9 <22",
"node": ">=20.11.1 <22",
"npm": ">=10"
},
"workspaces": [
Expand Down
2 changes: 1 addition & 1 deletion packages/insomnia-send-request/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"main": "dist/index.js",
"types": "dist/send-request/index.d.ts",
"dependencies": {
"@getinsomnia/node-libcurl": "2.4.29-5",
"@getinsomnia/node-libcurl": "^2.4.30",
"@segment/analytics-node": "2.1.0",
"@stoplight/spectral-core": "^1.18.3",
"@stoplight/spectral-formats": "^1.6.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/insomnia/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@bufbuild/protobuf": "^1.8.0",
"@connectrpc/connect": "^1.4.0",
"@connectrpc/connect-node": "^1.4.0",
"@getinsomnia/node-libcurl": "2.4.29-5",
"@getinsomnia/node-libcurl": "^2.4.30",
"@grpc/grpc-js": "^1.10.6",
"@grpc/proto-loader": "^0.7.12",
"@jest/globals": "^29.7.0",
Expand Down Expand Up @@ -143,7 +143,7 @@
"cross-env": "^7.0.3",
"date-fns": "^3.6.0",
"deep-equal": "^1.0.1",
"electron": "29.3.0",
"electron": "30.0.9",
"electron-builder": "24.13.3",
"electron-builder-squirrel-windows": "24.13.3",
"electron-devtools-installer": "^3.2.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ export const ResponseMultipartViewer: FC<Props> = ({

// Save the file
try {
// @ts-expect-error -- TSCONVERSION if filePath is undefined, don't try to write anything
await fs.promises.writeFile(filePath, selectedPart.value);
} catch (err) {
console.warn('Failed to save multipart to file', err);
Expand Down
6 changes: 3 additions & 3 deletions shell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ with import <nixpkgs> { };

mkShell {
nativeBuildInputs = [
nodejs-20_x
electron_29
nodejs_20
electron_30
stdenv.cc.cc.lib
];
LD_LIBRARY_PATH = "${stdenv.cc.cc.lib}/lib64:$LD_LIBRARY_PATH";
ELECTRON_OVERRIDE_DIST_PATH = "${electron_29}/bin/";
ELECTRON_OVERRIDE_DIST_PATH = "${electron_30}/bin/";
ELECTRON_SKIP_BINARY_DOWNLOAD = 1;
}

0 comments on commit 50965a4

Please sign in to comment.