fix race condition and cleanup code

packages/insomnia/src/ui/routes/actions.tsx

@@ -737,6 +737,7 @@ export const generateCollectionFromApiSpecAction: ActionFunction = async ({
   const spectralRunner = new SpectralRunner();
 
   const results = (await spectralRunner.runDiagnostics({ contents: apiSpec.contents, rulesetPath })).filter(isLintError);
+  spectralRunner.terminate();
   if (apiSpec.contents && results && results.length) {
     throw new Error('Error Generating Configuration');
   }

packages/insomnia/src/ui/routes/design.tsx

@@ -234,20 +234,19 @@ const Design: FC = () => {
     message => message.type === 'warning'
   );
 
-  const runnerRef = useRef<SpectralRunner>();
+  const spectralRunnerRef = useRef<SpectralRunner>();
 
   const registerCodeMirrorLint = (rulesetPath: string) => {
     CodeMirror.registerHelper('lint', 'openapi', async (contents: string) => {
-      let runner = runnerRef.current;
+      let runner = spectralRunnerRef.current;
 
       if (!runner) {
         runner = new SpectralRunner();
-        runnerRef.current = runner;
+        spectralRunnerRef.current = runner;
       }
 
       try {
         const diagnostics = await runner.runDiagnostics({ contents, rulesetPath });
-
         const lintResult = diagnostics.map(({ severity, code, message, range }) => {
           return {
             from: CodeMirror.Pos(
@@ -280,7 +279,7 @@ const Design: FC = () => {
   useUnmount(() => {
     // delete the helper to avoid it run multiple times when user enter the page next time
     CodeMirror.registerHelper('lint', 'openapi', undefined);
-    runnerRef.current?.terminate();
+    spectralRunnerRef.current?.terminate();
   });
 
   const onCodeEditorChange = useMemo(() => {

packages/insomnia/src/ui/worker/spectral.ts

@@ -3,7 +3,7 @@ import { Spectral } from '@stoplight/spectral-core';
 // @ts-expect-error - tsconfig needs to be updated to separate main/renderer code
 import { bundleAndLoadRuleset } from '@stoplight/spectral-ruleset-bundler/with-loader';
 import { oas } from '@stoplight/spectral-rulesets';
-import fs from 'fs/promises';
+import fs from 'fs';
 
 interface SpectralRunParams {
   contents: string;

packages/insomnia/src/ui/worker/spetral-run.ts

@@ -16,15 +16,14 @@ export class SpectralRunner {
   }
 
   public async runDiagnostics({ contents, rulesetPath }: { contents: string; rulesetPath: string }) {
-    this.taskId = this.taskId++;
-    return new Promise<ISpectralDiagnostic[]>((resolve, reject) => {
+    this.taskId = ++this.taskId;
+    return new Promise<ISpectralDiagnostic[]>(resolve => {
       this.worker.onmessage = e => {
         const { id, diagnostics } = e.data;
 
+        // onmessage callback will be called several times in one promise, and promise can be resolved or rejected only once, so we cant reject it here
         if (id === this.taskId && diagnostics) {
           resolve(diagnostics);
-        } else {
-          reject(e.data);
         }
       };