Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for folder/request group descriptions #3306

Closed
develohpanda opened this issue Apr 20, 2021 · 1 comment · Fixed by #3350
Closed

Add support for folder/request group descriptions #3306

develohpanda opened this issue Apr 20, 2021 · 1 comment · Fixed by #3350
Labels
A-ui-ux Area: UI / UX / Design E-good-first-issue Experience required: Beginner / New

Comments

@develohpanda
Copy link
Contributor

develohpanda commented Apr 20, 2021

Currently, collection descriptions and request descriptions can be added from their respective settings:
image
image

However the same does not exist for request groups/folders.

The initial feature request (#196) was closed by a PR which only adds UI request descriptions), so there is a clear gap here for request group settings.

I imagine we should change the "rename" button and modal of request group actions to be "Settings", and allow for the addition of a description like the screenshots above.

There is some related conversation here: insodoc/insomnia-documenter#29.

@develohpanda develohpanda added E-good-first-issue Experience required: Beginner / New C-feature-accepted A-ui-ux Area: UI / UX / Design labels Apr 20, 2021
@NickHackman
Copy link
Contributor

I'd be happy to work on this as my first feature in Insomnia, just would like some clarification on what the documentation for a folder/group would look like, I assume something similar to a request, but that would require that click on a group/folder would open up a page for docs.

I think opening the docs (in the request view/area) and expanding the folder/group is an obvious and solid approach. It would also have the benefit of being easily expanded upon, allowing in the future to have Folder Plugins as buttons on the far right side of where requests have headers/authorization or other group/folder features (ie: authorization, headers, etc). Anyways, just like to ensure that I'm on the same page here.

NickHackman added a commit to NickHackman/insomnia that referenced this issue May 2, 2021
Adds the ability to modify the description for a Request Group in a modal shown by hitting settings in a dropdown. Identical implementation to RequestSettings. In addition allows renaming the Request Group as well as moving/copying it to a different workspace.

Ref: Kong#3306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui-ux Area: UI / UX / Design E-good-first-issue Experience required: Beginner / New
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants