Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback user agent to OAuth requests #6425

Closed
1 task done
ocasta opened this issue Aug 30, 2023 · 2 comments · Fixed by #6429
Closed
1 task done

Add fallback user agent to OAuth requests #6425

ocasta opened this issue Aug 30, 2023 · 2 comments · Fixed by #6429
Labels
A-oauth Area: OAuth B-bug Bug: general classification

Comments

@ocasta
Copy link

ocasta commented Aug 30, 2023

Expected Behavior

I don't understand why the User Agent was removed by default (#6109) when it is a key HTTP header. All our firewalls reject requests without a User Agent.

While there is a suggested, not documented, workaround in answer to #6399 this does not add the User Agent to OAuth 2 authentication requests. I also found that it didn't work for API calls when defined in the Base Environment only when defined in the sub-environment

The definition of alternative User Agent strings needs to affect all requests not just API calls

Actual Behavior

User Agent defined in Base or Sub Environment is not added to OAuth request

Reproduction Steps

No response

Is there an existing issue for this?

Additional Information

No response

Insomnia Version

2023.5.7

What operating system are you using?

macOS

Operating System Version

Ventura 13.4.1

Installation method

Download from Insomnia

Last Known Working Insomnia version

2023.4

@ocasta ocasta added B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Aug 30, 2023
@subnetmarco
Copy link
Member

@jackkav Just so I understand, we allowed the user-agent to be customizable on the Headers tab for each request, but that's the only change we made? Therefore a user-agent should still appear for each request?

@jackkav jackkav added A-oauth Area: OAuth and removed B-bug Bug: general classification S-unverified Status: Unverified by maintainer labels Aug 30, 2023
@jackkav jackkav changed the title No way to specify a User Agent for an OAuth request Feature: Custom User Agent for an OAuth request Aug 30, 2023
@jackkav jackkav changed the title Feature: Custom User Agent for an OAuth request Add fallback user agent to OAuth requests Aug 30, 2023
@jackkav jackkav added the B-bug Bug: general classification label Aug 30, 2023
@jackkav
Copy link
Contributor

jackkav commented Aug 30, 2023

fixed in: #6429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-oauth Area: OAuth B-bug Bug: general classification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants