Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make user-agent optional #6109

Merged
merged 6 commits into from Jul 7, 2023
Merged

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Jul 7, 2023

closes #4065
closes INS-2811

changelog(Improvements): User-agent is now explicit in headers and optional

@jackkav jackkav enabled auto-merge July 7, 2023 06:18
@jackkav jackkav requested a review from a team July 7, 2023 06:19
@jackkav jackkav added this pull request to the merge queue Jul 7, 2023
Merged via the queue into Kong:develop with commit b4c450f Jul 7, 2023
9 checks passed
@jackkav jackkav deleted the fix/optional-user-agent branch July 7, 2023 10:42
@vcruzmj
Copy link

vcruzmj commented Aug 23, 2023

Question: after this issue was released in 2023.5.0, there is no option (UI level) to add or enable the user-agent globally, and this is removed by default, and can only be added as a header per request.

This is the intended result of this?

jackkav added a commit to jackkav/insomnia that referenced this pull request Nov 24, 2023
* make user-agent optional

* suppress default

* fix test

* fix tests

* fix user agent tests

* remove import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants