Download path settings per request #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develohpanda
changed the title
Yes, I agree. It would be nice for the future but out of scope for this PR. |
gschier
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Thanks again @develohpanda! I have nothing to add on this one 😄 👍
|
Thanks for the pull-request @develohpanda - can't wait to test this out |
No worries mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1511.
Saves request download path in
request-metainstead ofrequest-url-barstate. This allows the setting to be per request rather than global.Ideally I would expect this
downloadPathsetting (and others in future) to exist in a 'requestSettings` object in meta and passed around as a whole rather than adding x props for each new setting. I feel that is out of scope for this PR though - thoughts?Send + download
Send only
