Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape dirs in the yarn cmd #1688

Merged
merged 1 commit into from Sep 30, 2019
Merged

Escape dirs in the yarn cmd #1688

merged 1 commit into from Sep 30, 2019

Conversation

v1ktor
Copy link
Contributor

@v1ktor v1ktor commented Sep 27, 2019

Fixes #1355

The yarn doesn't understand spaces in path, so they have to be escaped.

@welcome
Copy link

welcome bot commented Sep 27, 2019

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@v1ktor v1ktor changed the title Escape dirs in the yarn cmd #1355 Escape dirs in the yarn cmd Sep 27, 2019
Copy link
Contributor

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! That probably explains some of the intermittent plugin install problems people have been reporting.

@gschier gschier merged commit e1c185c into Kong:develop Sep 30, 2019
@welcome
Copy link

welcome bot commented Sep 30, 2019

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

@v1ktor
Copy link
Contributor Author

v1ktor commented Oct 3, 2019

I have downloaded 7.0.0 update today and unfortunately It didn't fully fix the issue on windows. The _getYarnPath() also should be escaped, but I have missed that since yarn-standalone was installed in the path without space on my local env :(

I will verify and do another PR soon.

@v1ktor v1ktor deleted the issue/1355 branch October 3, 2019 11:05
@v1ktor v1ktor mentioned this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space in installation directory breaks plugin installation on Windows
2 participants