[Feature] Prettify Json When Saving Response To File #1829
Conversation
There was a problem hiding this comment.
Hey @elemanhillary, thanks for taking a crack at this! I've left quite a few comments here so let me know if you have any questions.
I also think we should present an additional dropdown button to save "prettified" response because saving the original un-prettified response is still something that should be possible.
elemanhillary-zz
force-pushed
the
feature/prettify_json_when_saving_response
branch
3 times, most recently
from
cf04e5a
to
4f564f4
Compare
| @@ -96,11 +98,21 @@ class ResponsePane extends React.PureComponent<Props> { | |||
| } | |||
|
|
|||
| const readStream = models.response.getBodyStream(response); | |||
| let responseBody = ''; | |||
There was a problem hiding this comment.
Since this is a string, your logic will force data to be converted from a Buffer a string. For binary data, we need to ensure that it remains a Buffer if it's not a string content-type (eg. PDF document, Image, or mp3).
There's some other code that does this over here that can be referenced:
| }); | ||
| readStream.on('end', () => { | ||
| const to = fs.createWriteStream(outputPath); | ||
| to.write(prettify.json(responseBody)); |
There was a problem hiding this comment.
Nice! I think the only thing left to do here is add a check to see if the content type is actually JSON.
There is a contentType variable defined above that can be used to see if it contains the substring json. If it is not JSON, we should leave it unprocessed.
There was a problem hiding this comment.
i don't know how i forgot that but let me work on it, it's that i get to work on insomnia when am over worked at my work place
There was a problem hiding this comment.
No rush @elemanhillary, we're just grateful you're contributing 😄
Also, we're happy to help finish this one if you don't have the time 🤗
elemanhillary-zz
force-pushed
the
feature/prettify_json_when_saving_response
branch
from
4f564f4
to
7872f6d
Compare
|
This should be an option and not done by default. Saving the response with whitespace can increase the file size considerably. |
Closes #764