Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and package to a folder prefixed by the application id #2537

Merged
merged 2 commits into from
Aug 22, 2020

Conversation

develohpanda
Copy link
Contributor

This will allow us to concurrently build and smoke test both applications, as their artifacts will end up in different directories instead of overwriting each other.

image

  • I was able to npm run app-start - development worked fine
  • I was able to npm run app-build - see the artifacts in the expected directory and run smoke tests on them
  • I was able to npm run app-package - see the artifacts in the expected directory and run smoke tests on them

Related to #2535

@develohpanda develohpanda self-assigned this Aug 21, 2020
@develohpanda develohpanda added this to Needs Review ❤ in Insomnia Kanban Aug 21, 2020
@netlify
Copy link

netlify bot commented Aug 21, 2020

Deploy preview for insomnia-storybook ready!

Built with commit 7679822

https://deploy-preview-2537--insomnia-storybook.netlify.app

@daelid237
Copy link

how tips and trick secrete to get apps pinjaman online from goole play?

@develohpanda develohpanda merged commit c3678d6 into develop Aug 22, 2020
Insomnia Kanban automation moved this from Needs Review ❤ to Done 🎉 Aug 22, 2020
@develohpanda develohpanda deleted the update-build-dist-folders branch August 22, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Insomnia Kanban
  
Done 🎉
Development

Successfully merging this pull request may close these issues.

None yet

3 participants