Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add designer smoke tests to CI #2549

Merged
merged 1 commit into from
Aug 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@ jobs:
run: npm test
- name: Build core for smoke tests
run: npm run app-build:smoke:core
- name: Build designer for smoke tests
run: npm run app-build:smoke:designer
- name: Run core smoke tests
run: npm run test:smoke:core
- name: Run designer smoke tests
run: npm run test:smoke:designer
Windows:
name: Test Windows
runs-on: windows-latest
Expand All @@ -49,8 +53,12 @@ jobs:
run: npm test
- name: Build core for smoke tests
run: npm run app-build:smoke:core
- name: Build designer for smoke tests
run: npm run app-build:smoke:designer
- name: Run core smoke tests
run: npm run test:smoke:core
- name: Run designer smoke tests
run: npm run test:smoke:designer
Linux:
name: Test Linux
runs-on: ubuntu-latest
Expand All @@ -69,5 +77,9 @@ jobs:
run: npm test
- name: Build core for smoke tests
run: npm run app-build:smoke:core
- name: Build designer for smoke tests
run: npm run app-build:smoke:designer
- name: Run core smoke tests
run: npm run test:smoke:core
- name: Run designer smoke tests
run: npm run test:smoke:designer
6 changes: 3 additions & 3 deletions packages/insomnia-smoke-test/designer/app.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ describe('Application launch', function() {
// path: '/Applications/Insomnia.app/Contents/MacOS/Insomnia',

// Run after app-package - mac
// path: path.join(__dirname, '../insomnia-app/dist/com.insomnia.app/mac/Insomnia.app/Contents/MacOS/Insomnia'),
// path: path.join(__dirname, '../insomnia-app/dist/com.insomnia.designer/mac/Insomnia.app/Contents/MacOS/Insomnia'),

// Run after app-package - Windows
// path: path.join(__dirname, '../insomnia-app/dist/com.insomnia.app/win-unpacked/Insomnia.exe'),
// path: path.join(__dirname, '../insomnia-app/dist/com.insomnia.designer/win-unpacked/Insomnia.exe'),

// Run after app-build - mac, Windows, Linux
path: electronPath,
args: [path.join(__dirname, '../../insomnia-app/build/com.insomnia.app')],
args: [path.join(__dirname, '../../insomnia-app/build/com.insomnia.designer')],

// Don't ask why, but don't remove chromeDriverArgs
// https://github.com/electron-userland/spectron/issues/353#issuecomment-522846725
Expand Down