Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Intermittent failures #3376

Merged
merged 2 commits into from May 13, 2021

Conversation

dimitropoulos
Copy link
Contributor

closes: INS-694

@dimitropoulos
Copy link
Contributor Author

dimitropoulos commented May 12, 2021

@develohpanda I think we may also need to specify peerDependencies correctly according to:

Specify any peerDependencies in the devDependencies of a given leaf package.json, and the topological order will be respected by lerna run.
lerna/lerna#2009 (comment)

@develohpanda
Copy link
Contributor

That seems logical, many of those weren't even in flow before so didn't need any build which might explain why it JustWorked™️ before

@develohpanda
Copy link
Contributor

@dimitropoulos that link actually states that any peerDependencies should be specified as devDependencies. In insomnia-app, most of these are actually specified as dependencies; I don't know if that will have an issue in future but we can cross that bridge if we get to it

@develohpanda
Copy link
Contributor

I removed the peerDependencies commit for now, I think removing the --parallel had already fixed it, and if it doesn't we can revisit this.

Looking at the lerna docs, the --parallel option explicitly ignores toplogical order

@develohpanda develohpanda marked this pull request as ready for review May 13, 2021 02:41
@vercel vercel bot temporarily deployed to Preview May 13, 2021 02:42 Inactive
@develohpanda develohpanda merged commit 5dad243 into Kong:develop May 13, 2021
@develohpanda develohpanda deleted the windows-ci-failures branch May 13, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants