-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme preview tile for OS themes #3387
Conversation
Not sure about the failing test in macOS since I can't test the application in that environment but it seems it's not reproducible in Windows/Linux. Do you know what could be the cause? |
Seemed to be a smoke test timeout, these can happen sometimes. I have re-run 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be working, thanks for the PR! 👏🏽
Seems fine to me for the time being. We do have another task to bring the OS color scheme selector above the list of themes (instead of below, as it is now), and in that case hiding the previous would work better. I pulled this branch locally and did a quick experiment with moving the selector and changing the behavior slightly, but will need some design feedback before going ahead with the following. This is unrelated to your PR though, which can go through regardless (pending another review/QA). |
Thanks for your review @develohpanda! I'm going to have a look at the issues page and start working on another issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from prod -- I love the feel of instant results.
Closes #3358 🎉
What I did?
svg
that is used to preview the theme into a function namedrenderThemePreview
.renderThemePreview
under the select dropdown used for selecting the theme if the optionuse OS color scheme
is enabled.From the feature request:
I decided not to hide the preview tile and instead rendered it disabled since it was hard to notice that the preview tile appeared on the bottom of the select just by looking at the scrollbar. Here you can find the problem I'm trying to describe:
screen-capture.64.mp4
The final implementation looks as follows:
screen-capture.65.mp4
Let me know if you see anything that can be improved, I'll change it ASAP.